-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP8 #84
base: master
Are you sure you want to change the base?
Support PHP8 #84
Conversation
830cfd2
to
4065ae6
Compare
@jwage did you notice this Pull Request? |
@dpi on PHP 8.1 this kind of deprecation messages is generated:
Might be useful to also resolve this in your patch? https://github.com/dpi/purl/blob/php8/src/Purl/AbstractPart.php#L139 |
Id like to get a preference from the maintainer. Whether he prefers to litter the current branch with attributes or fix the issue with a new major/minor. Or both. |
@dpi yeah I agree @jwage any thoughts on this? I gave it a shot myself at https://github.com/holtkamp/purl/tree/patch-php-8.1 for PHP 8.1 to reduce the amount of errors reported by monitoring tools like New Relic |
This a great util library, but it seems like it may be abandoned? Anyone have suggestions for an alternate library? |
I am no longer personally using this library and don't have the time to maintain it. Happy to hand over the maintenance to someone else. Here is an alternative maintained library https://uri.thephpleague.com/ |
Fixes #83
doctrine/coding-standard ^6 and ^7 only supports PHP ^7.1, so updated to branch 8. (9 is also available.)
Updated phpstan/phpstan + phpstan/phpstan-strict-rules from ^0.11 to ^0.12 to support PHP 8.
Removed PHP 5 reference from composer.json
Ran phpcbf, which fixed all CS fails as a result of updating.
The two removed sniffs no longer exist (didnt look for the replacements, if any)
__set magic method is only allowed to return void in PHP8: https://3v4l.org/uiGk3