Bugfix: TSFE->cObj not available on shortcut pages #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the TypeError JWeiland\Replacer\Helper\TypoScriptHelper::getContentObjectRenderer(): Return value must be of type TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer, null returned that occurs, when you visit a shortcut page with its original slug. Resolves: jweiland-net#2
| if (!$this->getTypoScriptFrontendController()->isINTincScript() || $response instanceof NullResponse) { | ||
| if (!$this->getTypoScriptFrontendController()->isINTincScript() | ||
| || $response instanceof NullResponse | ||
| || $this->getContentObjectRenderer() === null |
There was a problem hiding this comment.
Alternatively we could check isset($this->getTypoScriptFrontendController()->page['_SHORTCUT_ORIGINAL_PAGE_UID'])
|
As this PR is solving an error preventing us from updating to the latest version i would love to see it being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the TypeError
JWeiland\Replacer\Helper\TypoScriptHelper::getContentObjectRenderer(): Return value must be of type TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer, null returned
that occurs, when you visit a shortcut page with its original slug.
Resolves: #2