Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[bp/1.28] Fix build error with
maxmind
if http3 is disabled (envoyp…
…roxy#33638) `maxmind` is causing the build to not honor the flag `--//bazel:http3=False`: The define `ENVOY_ENABLE_QUIC` is still being passed to the compiler. This causes code that rely on the presence (or not) of that define to behave wrongly. I am not 100% sure of what causes it, but Bazel doc says 1) to not use `bind` and 2) that `bind` and `select` do not play well together: https://bazel.build/reference/be/workspace#bind By removing the `bind` and pointing directly to the actual dependency in `maxmind` BUILD file, we fix this issue. Backport of envoyproxy#33638 Signed-off-by: Jonh Wendell <jwendell@redhat.com>
- Loading branch information