-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension migration for JupyterLab 2.x #115
base: master
Are you sure you want to change the base?
Conversation
Modification have been done according to the migration guide: <https://jupyterlab.readthedocs.io/en/stable/developer/extension_migration.html> - Update dependencies - Change @phosphor/* to @lumino/* - Change ``ReadonlyJSONObject`` to ``ReadonlyPartialJSONObject`` - Session is now accessible from ``NotebookPanel.sessionContext`` instead of ``NotebookPanel.session`` - Change required version in README
Already used your code. Thanks! |
Your welcome, while this or another solution gets merged, I have published the npm package as @axlair/jupyterlab_vim as a temporary solution. |
Thanks so much for making these updates! I've just installed the extension you published to temporarily replace
Seems odd. Is there anything else that needs to be done to make the extension active? |
I don't think there is anything else to do to activate the extension. Maybe one of your browser's extension is conflicting with the plugin. I am using Firefox and I don't have any issue, however on Chromium, if I have the plugin |
@zaneselvans I had a similar issue. resolved it by clearing out my virtual env entirely and rebuilding from scratch |
Hi, I am not too familiar with npm, but i did the following and it doesn't seem to be working:
What am I doing wrong? TIA Solution: Got it to work. Cloned your repository and did:
Thanks for this work |
I'm really looking forward to use the vim plugin in Jupyter Lab 2.0. :) |
Hello! I'm getting the following exception. Am I applying this incorrectly, or it's correct but my versions are not supported?
Thank you! |
What is your jupyterlab version? Have you tried in a new environment with a fresh installation of jupyterlab? |
@axelfahy Hi. Yes its a fresh install of |
Hi @nmvega, Did you execute this command to install @axelfahy 's build? I think executing: |
@TheGhostHuCodes Hello! I did not try that variation. I'm unfamiliar with the |
@TheGhostHuCodes @axelfahy So for the those visiting here, the complete solution is:
I then reloaded my Notice that I did this under the @axelfahy Thank for you this solution. I've been using |
Modifications have been done according to the migration guide:
https://jupyterlab.readthedocs.io/en/stable/developer/extension_migration.html
Update dependencies
Change @phosphor/* to @lumino/*
Change
ReadonlyJSONObject
toReadonlyPartialJSONObject
Session is now accessible from
NotebookPanel.sessionContext
instead of
NotebookPanel.session
Change required version in README
This should close #113
Please finish the following when submitting a pull request:
History.md
briefly documenting the change.If this is a release, additionally do the following:
package.json
package.json
jlpm install
to updateyarn.lock
Thanks!