Skip to content

Commit

Permalink
Run on Node 20 (#66)
Browse files Browse the repository at this point in the history
GitHub is no longer going to support running actions on Node 16 and requires upgrading to Node 20 (see blog). This PR addresses that with updates to:

 * action runtime
 * workflows
 * node types

Tests passed when run locally. Closes #65.

Add @types/node to devDependencies to ensure we get the proper version and bump @vercel/ncc to the latest, and update package-lock using `npm install` which also prepares the package.
  • Loading branch information
joshstrohminger authored Feb 6, 2024
1 parent d06b37b commit 8974e9c
Show file tree
Hide file tree
Showing 8 changed files with 3,372 additions and 6,123 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup cmake
uses: ./
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup cmake
uses: ./
Expand Down Expand Up @@ -51,12 +51,12 @@ jobs:

steps:
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '16.x'
node-version: '20.x'

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install node dependencies
run: npm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup cmake
uses: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-32bit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup cmake
uses: ./
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ inputs:
description: 'Force using 32 bit version of cmake, instead of looking for 64 bit version'
default: 'false'
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
4 changes: 3 additions & 1 deletion dist/index.js

Large diffs are not rendered by default.

Loading

0 comments on commit 8974e9c

Please sign in to comment.