Skip to content

Commit

Permalink
Medianet RTD module: fix getTargetingData to retrieve correct adUni…
Browse files Browse the repository at this point in the history
…ts (prebid#9392)
  • Loading branch information
dgirardi authored and jorgeluisrocha committed May 18, 2023
1 parent 7f0205a commit b7e4963
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions modules/medianetRtdProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ function onAuctionInitEvent(auctionInit) {
}, SOURCE));
}

function getTargetingData(adUnitCode) {
const adUnits = getAdUnits(undefined, adUnitCode);
function getTargetingData(adUnitCodes, config, consent, auction) {
const adUnits = getAdUnits(auction.adUnits, adUnitCodes);
let targetingData = {};
if (window.mnjs.loaded && isFn(window.mnjs.getTargetingData)) {
targetingData = window.mnjs.getTargetingData(adUnitCode, adUnits, SOURCE) || {};
targetingData = window.mnjs.getTargetingData(adUnitCodes, adUnits, SOURCE) || {};
}
const targeting = {};
adUnitCode.forEach(adUnitCode => {
adUnitCodes.forEach(adUnitCode => {
targeting[adUnitCode] = targeting[adUnitCode] || {};
targetingData[adUnitCode] = targetingData[adUnitCode] || {};
targeting[adUnitCode] = {
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/medianetRtdProvider_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,20 +66,20 @@ describe('medianet realtime module', function () {
describe('getTargeting should work correctly', function () {
it('should return empty if not loaded', function () {
window.mnjs.loaded = false;
assert.deepEqual(medianetRTD.medianetRtdModule.getTargetingData([]), {});
assert.deepEqual(medianetRTD.medianetRtdModule.getTargetingData([], {}, {}, {}), {});
});

it('should return ad unit codes when ad units are present', function () {
const adUnitCodes = ['code1', 'code2'];
assert.deepEqual(medianetRTD.medianetRtdModule.getTargetingData(adUnitCodes), {
assert.deepEqual(medianetRTD.medianetRtdModule.getTargetingData(adUnitCodes, {}, {}, {}), {
code1: {'mnadc': 'code1'},
code2: {'mnadc': 'code2'},
});
});

it('should call mnjs.getTargetingData if loaded', function () {
window.mnjs.loaded = true;
medianetRTD.medianetRtdModule.getTargetingData([]);
medianetRTD.medianetRtdModule.getTargetingData([], {}, {}, {});
assert.equal(getTargetingDataSpy.called, true);
});
});
Expand Down

0 comments on commit b7e4963

Please sign in to comment.