feat: cdn analytics code cleanup

jwplayer · Jan 12, 2024 · d92937d · d92937d
1 parent 114150e
commit d92937d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/components/Player/Player.tsx b/src/components/Player/Player.tsx
@@ -13,7 +13,7 @@ import { useConfigStore } from '#src/stores/ConfigStore';
 import type { AdSchedule } from '#types/ad-schedule';
 import { useAccountStore } from '#src/stores/AccountStore';
 import { useProfileStore } from '#src/stores/ProfileStore';
-import { attachAnalyticsParams } from '#src/utils/player';
+import { attachAnalyticsParams } from '#src/utils/analytics';
 
 type Props = {
   feedId?: string;
@@ -174,8 +174,7 @@ const Player: React.FC<Props> = ({
       playerRef.current = window.jwplayer(playerElementRef.current) as JWPlayer;
 
       // Inject user_id and profile_id into the CDN analytics
-      const { sources, mediaid } = item;
-      attachAnalyticsParams(sources, mediaid, isJwIntegration, userId, profileId);
+      attachAnalyticsParams(item, isJwIntegration, userId, profileId);
 
       // Player options are untyped
       const playerOptions: { [key: string]: unknown } = {

diff --git a/src/utils/player.ts → src/utils/analytics.ts b/src/utils/player.ts → src/utils/analytics.ts
@@ -1,6 +1,8 @@
-import type { Source } from '#types/playlist';
+import type { PlaylistItem, Source } from '#types/playlist';
+
+export const attachAnalyticsParams = (item: PlaylistItem, isJwIntegration: boolean, userId?: string, profileId?: string) => {
+  const { sources, mediaid } = item;
 
-export const attachAnalyticsParams = (sources: Source[], mediaid: string, isJwIntegration: boolean, userId?: string, profileId?: string) => {
   return sources.map((source: Source) => {
     const url = new URL(source.file);
 
@@ -12,7 +14,7 @@ export const attachAnalyticsParams = (sources: Source[], mediaid: string, isJwIn
       url.searchParams.set('user_id', userId);
 
       if (isJwIntegration && profileId) {
-        url.searchParams.append('profile_id', profileId);
+        url.searchParams.set('profile_id', profileId);
       }
     }