chore: remove faker (unused) #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 96d336c): https://ottwebapp--pr380-dbudzins-faker-moj8iirz.web.app (expires Sat, 28 Oct 2023 11:53:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
ChristiaanScheermeijer
approved these changes
Sep 28, 2023
dbudzins
added a commit
that referenced
this pull request
Oct 11, 2023
* feat(user): hw manage profiles * fix: watch history bug * feat: custom register fields * feat: updated test snaps * feat: add spacing between custom register fields * feat: created CustomRegisterField.test.tsx * fix: implement custom register fields in Account section * fix: removed redundant conversion to string * fix: consent checkbox wasn't rendered for cleeng * fix: update Account.tsx * fix: fixed consent updating in Account section * fix: lint error * fix: type casting to supress incorrect type from SDK * fix: cleanup from a redundant condition * fix: remove redundant destructuring * feat: implement "datepicker" as the last custom register field * fix: re-introduce the new "other_registration_details" translation line * fix: removed a no longer valid comment * fix: replaced ConsentFieldVariants enum with union types * fix: don't display "first_name" and "surname" custom register fields in registration step 1 * fix: revert one of the last changes * fix: revert last change * fix: re-introduced the previously reverted changes * feat: refactor profiles calls to services and controllers * chore: upgrade inplayer.js version * fix: fix form type in update profile * fix: avoid using auth provider name in components * feat: add profiles to user menu * chore: move hooks from utils to hooks folder * feat(project): profiles loading overlay * chore: update tests * chore: update user menu test * feat(project): update edit and create forms * chore: fixes, renaming, translations * feat: selecting profiles * fix: pr comments * fix: pr comments * fix: border radius * fix: remove unnecessary helper text, rename class, fix profile persist on relog * fix: infinite rerender fix, refetch fix * fix: fix undefined in url * chore: update test * fix: profilebox css fixes * fix: check if user exists before redirecting to profiles * fix: bugs * Update Profiles.module.scss * Update CreateProfile.tsx * Update Profiles.module.scss * Update Profiles.module.scss * fix: sync with base branch * fix: update .depcheckrc.yaml * fix: bugs * fix: fix typescript error in vite.config.ts * feat(project): implement translation of CRF dropdown * feat: design changes, remove unnecessary logic, translations * chore: translations * fix: css design changes * fix: add config check for profiles feature * fix: countries and US states translated to Spanish * fix: updated country and US state codes * fix: refactor CustomRegisterField.tsx * fix: fix env, fix loader logic * chore: package.json tests * chore: remove unneeded comment * chore: update tests * fix: fix design related comments * fix: create profile service and controller * fix: update profile hooks with fetch logic * fix: fix user page tabs * feat(project): add an image label as a custom param for playlists * fix: pr comments * fix: pull request feedback corrections * fix: invalidate publisher consents on config change * fix: remove no longer necessary type casting * fix: show "optional" even when no label in Dropdown * fix: remove redundant "static" folder with json files * fix: update react-i18next mock in vitest.setup.ts * fix: translations, profiles refetch * fix: vqa2 fixes * fix: replaced an enum with union type * fix: remove unnecessary config check, add default avatar * Webapp bugs (#365) * fix: password reset * fix: comments pr * fix: comments * fix: comments * Update src/stores/AccountController.ts Co-authored-by: Kire Mitrov <k_mitrov@yahoo.com> * Update AccountController.ts * Update AccountController.ts * fix: comments --------- Co-authored-by: Kire Mitrov <k_mitrov@yahoo.com> * fix: appConfig from store instead of from search params * fix: rename a var * chore: cleeng consents tweaks * fix: add various profiles fixes and improvements * fix: add enabled flag for useProfiles * fix: invalidate listProfiles on register * fix: fixed reconciliation issue in FormSection * fix: add comment in DateField * fix: avoided response mapping in cleeng * fix: remove unnecessary localstorage key * fix: jwpltx crash fix and multiple test improvements * fix: null ref in jwpltx crashing e2e tests * chore(project): test fixes * chore: fix payments tests * chore: fix scrolling and finding tests * chore: fix more tests --------- Co-authored-by: Danny Budzinski <dbudzinski@jwplayer.com> * fix: rollback live channel links pending route refactor (#373) * fix: rollback live channel links pending route refactor * fix: use navigate hook instead of component * fix: useEffect for media live channel navigate * chore: fix live channel tests to not rely on hover style * fix: workaround weird concurrent usenavigate bug * fix: fix race condition with app config query param * chore(deps): bump get-func-name from 2.0.0 to 2.0.2 (#379) Bumps [get-func-name](https://github.com/chaijs/get-func-name) from 2.0.0 to 2.0.2. - [Release notes](https://github.com/chaijs/get-func-name/releases) - [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2) --- updated-dependencies: - dependency-name: get-func-name dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: remove faker (unused) (#380) * fix: Revert "Merge pull request #310 from jwplayer/feat/custom-reg-fields" (#382) This reverts commit a04a63c, reversing changes made to 4b870cc. * Revert "fix: Revert "Merge pull request #310 from jwplayer/feat/custom-reg-fields" (#382)" This reverts commit 8e4109c. * Revert "Revert "fix: Revert "Merge pull request #310 from jwplayer/feat/custom-reg-fields" (#382)"" This reverts commit 9c0a058. * Fix / notifications handler (#385) * fix: notifications handling improvements * chore: fix github actions * chore: fix github action name * chore: remove prerelease marker from action * chore: parse latest translation tags * chore(release): v4.28.0 * fix: add missing translations * chore: fix diff translation script * chore: fixup github action triggers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: kiremitrov123 <k_mitrov@yahoo.com> Co-authored-by: mirovladimitrovski <vladimir.dimitrovski@jwplayer.com> Co-authored-by: mirovladimitrovski <46674160+mirovladimitrovski@users.noreply.github.com> Co-authored-by: Filip Naumovski <filip.naumovski@jwplayer.com> Co-authored-by: naumovski-filip <111125899+naumovski-filip@users.noreply.github.com> Co-authored-by: Borislav Petrovikj <borislav.petrovikj@inplayer.com> Co-authored-by: borkopetrovicc <104987342+borkopetrovicc@users.noreply.github.com> Co-authored-by: Anton Lantukh <alantukh@jwplayer.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Release Script <ott-release-script@jwplayer.com> Co-authored-by: Conventional Changelog Action <conventional.changelog.action@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove faker.
This PR solves #378.
Steps completed:
According to our definition of done, I have completed the following steps:
- [ ] Unit tests added- [ ] Docs updated (including config and env variables)- [ ] Translations added