-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat / Maintenance 2024 q3 #608
Feat / Maintenance 2024 q3 #608
Conversation
9f2a322
to
353123c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the detailed PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I have 1 inline comment and one more here:
Running npx syncpack lint
produces an error. Syncpack is not mandatory, but keeps the package.json files clean and sync between packages/platforms.
The failure is a false-negative because we don't define the local packages as peer dependency anymore. So we can remove this rule in the .syncpackrc.json
file :-)
Thanks, updated! |
Maintenance 2024-Q3
At Videodock, we conduct quarterly maintenance to address any security risks and proactively upgrade the dependencies. This PR accomplishes that, with notable details outlined below.
Prepare
main
, runyarn
Update dependencies
yarn upgrade
and test dev server$ npx syncyarnlock -skgl
to sync theyarn.lock
file to thepackage.json
Major updates
date-fns
: No refactor neededdompurify
: No refactor neededzustand
: Some import changes, and a fix for a 'set' error we made inAppController
. Also: some deprecration warnings are introduced for the use ofshallow
. I suggest we fix this when Zustand 5 is here, which is already in 'rc'.Notes
ws
) can be removed once the Inplayer sdk has been removed