Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat / Maintenance 2024 q3 #608

Merged

Conversation

royschut
Copy link
Collaborator

@royschut royschut commented Sep 10, 2024

Maintenance 2024-Q3

At Videodock, we conduct quarterly maintenance to address any security risks and proactively upgrade the dependencies. This PR accomplishes that, with notable details outlined below.

Prepare

  • Pull main, run yarn
  • Test dev server and release build

Update dependencies

  • Run yarn upgrade and test dev server
  • Fix critical issues (must)
  • Fix high risk issues (should)
  • Fix moderate risk issues
  • Run $ npx syncyarnlock -skgl to sync the yarn.lock file to the package.json
  • Run linting, unit tests, e2e tests
  • Test dev server and release build
  • Test dev server and release build

Major updates

  • date-fns: No refactor needed
  • dompurify: No refactor needed
  • zustand: Some import changes, and a fix for a 'set' error we made in AppController. Also: some deprecration warnings are introduced for the use of shallow. I suggest we fix this when Zustand 5 is here, which is already in 'rc'.

Notes

  • Only 2 moderate issues left, but both are sub-dependencies of the Inplayer sdk, which is currently being removed from the web app
  • Removed obsolete resolutions
  • Added 3 resolutions to fix high risk issues, one of which (ws) can be removed once the Inplayer sdk has been removed

@royschut royschut force-pushed the feat/maintenance-2024-q3 branch from 9f2a322 to 353123c Compare September 10, 2024 14:37
Copy link
Collaborator

@langemike langemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the detailed PR description.

Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I have 1 inline comment and one more here:

Running npx syncpack lint produces an error. Syncpack is not mandatory, but keeps the package.json files clean and sync between packages/platforms.

The failure is a false-negative because we don't define the local packages as peer dependency anymore. So we can remove this rule in the .syncpackrc.json file :-)

@royschut
Copy link
Collaborator Author

The failure is a false-negative because we don't define the local packages as peer dependency anymore. So we can remove this rule in the .syncpackrc.json file :-)

Thanks, updated!

@ChristiaanScheermeijer ChristiaanScheermeijer merged commit 20ddad5 into jwplayer:develop Sep 16, 2024
9 checks passed
@ChristiaanScheermeijer ChristiaanScheermeijer deleted the feat/maintenance-2024-q3 branch September 16, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants