chore: update node version #622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiremitrov123
requested review from
AntonLantukh and
dbudzins
as code owners
|
Visit the preview URL for this PR (updated for commit aeab441): https://ottwebapp--pr622-chore-update-node-ve-7imshbu0.web.app (expires Sat, 26 Oct 2024 12:22:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
| @@ -4,9 +4,26 @@ import * as Sentry from '@sentry/node'; | |||
| import logger from '../../src/pipeline/logger.js'; | |||
|
|
|||
| describe('Logger Tests', () => { | |||
| // Preserve the original console methods | |||
| const originalConsole = { ...console }; | |||
There was a problem hiding this comment.
If you use a logger service this one may help:
mockService(
LogTransporter,
__debug__
? new ConsoleTransporter(LogLevel.DEBUG)
: {
log() {},
},
);
There was a problem hiding this comment.
No, I am using access bridge specific logger.
There was a problem hiding this comment.
It is possible that the memory issue we are facing is connected because the logger was outputting error objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the project's Node.js version to match the CI environment
(v20.17.0)and reverted the removal of sharp from the knip ignoreDependencies list to prevent potential issues.This PR solves # .
Steps completed:
According to our definition of done, I have completed the following steps: