Dynamically register algorithms to lookup as they get loaded #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakinj
force-pushed
the
extendable-algos
branch
from
a9303e7 to
0f1eba1
Compare
anakinj
changed the title
anakinj
changed the title
anakinj
force-pushed
the
extendable-algos
branch
from
249eb5f to
50e2dd1
Compare
anakinj
commented
Aug 24, 2024
anakinj
commented
Aug 24, 2024
anakinj
commented
Aug 28, 2024
anakinj
force-pushed
the
extendable-algos
branch
from
e967094 to
d7f680b
Compare
Co-authored-by: Matteo Pierro <pierromatteo@gmail.com>
anakinj
force-pushed
the
extendable-algos
branch
from
d7f680b to
ab8591a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamically generate the list of supported algorithms as implementations are loaded. This will allow replacing and extending the algorithm from outside of this gem.
Initial use-case would be to move the rbnacl related algorithms to a gem with an explicit dependency to the 3rd party crypto libs. More of that work can be looked at over here
Checklist
Before the PR can be merged be sure the following are checked: