Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trace and pprof #14

Merged
merged 1 commit into from
Mar 15, 2023
Merged

feat: add trace and pprof #14

merged 1 commit into from
Mar 15, 2023

Conversation

yusank
Copy link
Contributor

@yusank yusank commented Mar 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

To trace bugs and performance issues.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

DON'T merge this PR before update go mod fils

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@github-actions
Copy link

Please add a label from the following list: ['bug', 'documentation', 'duplicate', 'enhancement', 'good first issue', 'help wanted', 'invalid', 'question', 'size/L', 'size/M', 'wontfix']

@yusank yusank self-assigned this Mar 13, 2023
@yusank yusank requested a review from likakuli March 13, 2023 10:30
@yusank yusank added the enhancement New feature or request label Mar 13, 2023
@yusank yusank force-pushed the feature/add-pprof branch from 61b308b to 710298d Compare March 13, 2023 10:47
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #14 (df24eca) into main (6827122) will increase coverage by 40.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             main       #14       +/-   ##
============================================
+ Coverage   60.00%   100.00%   +40.00%     
============================================
  Files           2         2               
  Lines          55       104       +49     
============================================
+ Hits           33       104       +71     
+ Misses         22         0       -22     
Impacted Files Coverage Δ
cmd/app/options/options.go 100.00% <100.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yusan Kurban <yusankurban@gmail.com>
@yusank yusank force-pushed the feature/add-pprof branch from 710298d to df24eca Compare March 14, 2023 03:07
@likakuli likakuli merged commit 0e9bec9 into main Mar 15, 2023
@likakuli likakuli deleted the feature/add-pprof branch March 15, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants