-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend utf8 to 31bits #111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 62 62
Lines 12442 12442
=======================================
Hits 10276 10276
Misses 2166 2166
Continue to review full report at Codecov.
|
It seems that the modified codes are not tested on CI according to the result of Codecov.
|
I added execution of my new test to |
Thank you. Now I can check the coverage. Could you revert the changes to the generated files ( |
I pushed 3 commits.
|
Thank you for increasing the test coverage.
Could you revert the build files (to the same state as the master branch) instead of removing? |
Sorry my misunderstand. |
Thank you. |
Thanks to merge! |
This extends utf8 to 31bits.
Explanation of motivation is here #110
I implemented logic with same manner on original 21 bits logic.
I add test program for testing utf-8 codec.
It can execute following steps. (at least in my mac environment)
31bits mode is enabled by
USE_UTF8_31BITS
flag inutf8.c
.To ease testing this PR, I enabled it.
If this is accepted, I amend commit to disable it.
USE_UTF8_31BITS
flag is also intest_enc_utf8.c
.We need to keep that these two flag have same.
Finally, I attached my memo to implement decoding table.