Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Hugging Face API calls with Ollama #267

Closed
wants to merge 1 commit into from

Conversation

k-zehnder
Copy link
Owner

Description

This pull request refactors the summarization functionality to use the Ollama API instead of Hugging Face. The change is motivated by the availability of a dedicated machine capable of running Ollama, allowing for improved summary quality and performance.

Changes Made

  • Replaced Hugging Face API integration with Ollama API.
  • Adjusted prompt structure and response parsing for Ollama compatibility.
  • Updated Zod validation schema to align with Ollama response format.

Testing

  • Manually tested summarization with various articles to ensure consistent output.
  • Verified response parsing and validation against actual Ollama responses.
  • Updated and executed all relevant unit tests to validate integration.

Checklist

  • My code follows the style guidelines and best practices of this project.
  • I have reviewed and tested the code changes thoroughly.
  • I have added or updated unit tests to cover the modified code and ensure its correctness.
  • All existing unit tests pass with the changes.
  • The changes do not introduce any known security vulnerabilities.
  • I have considered the impact of these changes on performance, scalability, and maintainability.
  • The documentation has been updated to reflect the changes introduced (if applicable).

@k-zehnder k-zehnder closed this Dec 1, 2024
@k-zehnder k-zehnder deleted the staging branch December 1, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant