Handle Rails engine routes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Mar 24, 2022
lib/rspec/openapi/record_builder.rb
Outdated
| unless route.path.anchored | ||
| route = find_rails_route(request, app: route.app.app, fix_path: false) | ||
| found_route = nil | ||
| if app.respond_to? :routes |
There was a problem hiding this comment.
The tests don't fail even if you don't check if app.respond_to? :routes. Please remove this check or add a test that fails without this check.
|
To mitigate the risk of this change, I removed changes that are not needed to pass the test case. 81751cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let iterate all the recognized routes including the ones coming from Rails engines.
As reference, the relevant part of
action_dispatch'srecognize:https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/routing/route_set.rb#L881-L892
Fixes #37