Skip to content

Commit

Permalink
Remove redundant boxing
Browse files Browse the repository at this point in the history
  • Loading branch information
k0nserv committed May 6, 2024
1 parent c90b169 commit 0fa06d7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/geometry/mesh.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ use ray::Ray;
#[derive(Debug)]
pub struct Mesh<V, S> {
storage: S,
bounding_volume: Box<V>,
bounding_volume: V,
}

impl<'a, V: BoundingVolume, S: TriangleStorage<'a>> Mesh<V, S> {
pub fn new(triangles: Vec<Triangle>) -> Self {
let bounding_volume = Box::new(V::from_triangles(&mut triangles.iter()));
let bounding_volume = V::from_triangles(&mut triangles.iter());
let storage = S::new(triangles);

Self {
Expand Down Expand Up @@ -115,12 +115,12 @@ impl<V: BoundingVolume, S: for<'a> TriangleStorage<'a>> Transformable for Mesh<V
fn transform(&mut self, transform: &Transform) {
self.storage.transform(transform);

self.bounding_volume = Box::new(V::from_triangles(&mut self.storage.all()));
self.bounding_volume = V::from_triangles(&mut self.storage.all());
}

fn apply_transforms(&mut self, transforms: &[Transform]) {
self.storage.apply_transforms(transforms);
self.bounding_volume = Box::new(V::from_triangles(&mut self.storage.all()));
self.bounding_volume = V::from_triangles(&mut self.storage.all());
}
}

Expand Down

0 comments on commit 0fa06d7

Please sign in to comment.