Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let k0s cloud provider assign a node's provider ID #4228

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Let k0s cloud provider assign a node's provider ID #4228

merged 1 commit into from
Apr 22, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Apr 2, 2024

Description

Since kubernetes/kubernetes#123713, it is required for cloud providers to assign a provider ID to each node. Let k0s comply with that requirement.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added this to the 1.30 milestone Apr 2, 2024
@twz123 twz123 requested a review from a team as a code owner April 2, 2024 15:59
@twz123 twz123 requested review from ncopa and makhov April 2, 2024 15:59
@twz123 twz123 changed the title Let k0s-cloud provider assign a node's provider ID Let k0s cloud provider assign a node's provider ID Apr 2, 2024
@twz123
Let k0s-cloud provider assign a node's provider ID
11fbff0 
Since Kubernetes commit 53d38a31611, it is required for cloud providers
to assign a provider ID to each node. Let k0s comply with that
requirement.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 merged commit ae27910 into k0sproject:main Apr 22, 2024
74 checks passed
@twz123 twz123 deleted the k0s-cloud-provider-id branch April 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/controlplane chore
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @jnummelin