Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind Envoy NLLB to all localhost loopback IPs #4529

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bind Envoy NLLB to all localhost loopback IPs #4529

wants to merge 1 commit into from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented May 31, 2024

Description

This ensures that it will be reachable via IPv4 and IPv6 at the same time, instead of picking one of the two.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Bind Envoy NLLB to all localhost loopback IPs
1e62a78 
This ensures that it will be reachable via IPv4 and IPv6 at the same
time, instead of picking one of the two.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 force-pushed the envoy-bind-all-loopback-ips branch from a0abf43 to 1e62a78 Compare May 31, 2024 15:42
@github-actions GitHub Actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jun 30, 2024
@twz123
Copy link
Member Author

twz123 commented Jul 1, 2024

Need to figure out why the NLLB test is failing...

@github-actions github-actions bot removed the Stale label Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123