Deprecate the Calico ipip mode in favor of bird #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
added
documentation
jnummelin
previously approved these changes
Jul 3, 2024
|
@ncopa you mentioned that it might be a good idea to deprecate "mode" and use the calico terminology of "backend" instead, am I right? |
|
This pull request has merge conflicts that need to be resolved. |
jnummelin
previously approved these changes
Jul 12, 2024
|
This pull request has merge conflicts that need to be resolved. |
|
The PR is marked as stale since no activity has been recorded in 30 days |
|
This pull request has merge conflicts that need to be resolved. |
It's used via the receiver. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
K0s's Calico mode is directly passed to Calico as its backend. Calico only knows about bird, vxlan, windows-bgp and none. From the way the ipip mode is used in k0s, I figured that it's acutally the bird backend. Deprecate the ipip mode in k0s and pass on bird to Calico. Add constants and validation. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
jnummelin
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
K0s's Calico mode is directly passed to Calico as its backend. Calico only knows about bird, vxlan, windows-bgp and none. From the way the ipip mode is used in k0s, I figured that it's acutally the bird backend.
Deprecate the ipip mode in k0s and pass on bird to Calico. Add constants and validation.
Type of change
How Has This Been Tested?
Checklist: