feat(helm): add option to disable helm upgrade force flag

[emosbaugh]

Description

Adds the option disableForceUpgrade to the helm extensions chart spec.

When set to true, the "helm upgrade --force" flag is not longer used when upgrading the the chart.

Fixes #4864

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

• Manual test
• Auto test added

ethan@ethanm-ec-1:~/build/k0s$ sudo -E helm history -n registry docker-registry
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /var/lib/k0s/pki/admin.conf
REVISION	UPDATED                 	STATUS  	CHART                	APP VERSION	DESCRIPTION
1       	Fri Aug 16 18:01:44 2024	deployed	docker-registry-2.2.3	2.8.1      	Install complete

ethan@ethanm-ec-1:~/build/k0s$ sudo ./k0s kubectl -n kube-system apply -f k0s.yaml
clusterconfig.k0s.k0sproject.io/k0s configured
ethan@ethanm-ec-1:~/build/k0s$ sudo -E helm history -n registry docker-registry
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /var/lib/k0s/pki/admin.conf
REVISION	UPDATED                 	STATUS    	CHART                	APP VERSION	DESCRIPTION
1       	Fri Aug 16 18:01:44 2024	superseded	docker-registry-2.2.3	2.8.1      	Install complete
2       	Fri Aug 16 18:04:23 2024	deployed  	docker-registry-2.2.3	2.8.1      	Upgrade complete

  spec:
    extensions:
      helm:
        charts:
        - chartname: twuni/docker-registry
          name: docker-registry
          namespace: registry
          timeout: 0s
          # disableForceUpgrade: true
          values: |
            image:
              tag: 2.8.3
            persistence:
              accessMode: ReadWriteOnce
              enabled: true
              size: 10Gi
              storageClass: local-path
            replicaCount: 1
            storage: filesystem
            # extraEnvVars:
            # - name: TESTING
            #   value: "testing"
          version: 2.2.3
        concurrencyLevel: 5
        repositories:
        - name: twuni
          url: https://helm.twun.io

Checklist:

• My code follows the style guidelines of this project
• My commit messages are signed-off
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[jnummelin]

In general I'm in favor for adding option to use/not use force.

The only thing I'm thinking is in which way the option should be defined. I wonder if we could define the flag as useForce (or just plain force) while still defaulting it to true for backwards compatibility? Maybe if we'd define it as a pointer and then check if it was defined or not. 🤔

[emosbaugh]

In general I'm in favor for adding option to use/not use force.

The only thing I'm thinking is in which way the option should be defined. I wonder if we could define the flag as useForce (or just plain force) while still defaulting it to true for backwards compatibility? Maybe if we'd define it as a pointer and then check if it was defined or not. 🤔

@jnummelin thank you for the feedback! i've changed the field to a bool pointer forceUpgrade

[emosbaugh]

I've forgot to signoff on my commit. Re-pushed.

[emosbaugh]

@jnummelin ping here. anything I can do to get this over the finish line?

[github-actions]

This pull request has merge conflicts that need to be resolved.

[jnummelin]

@emosbaugh unfortunately there's now some conflicts. Give me a ping once you've been able to resolve and I'll review

[emosbaugh]

@jnummelin ive rebased

[jnummelin]

Should we have the defaulting with kubebuilder here too, something like:

	// +kubebuilder:default=true
	// +optional

[emosbaugh]

Thank you @jnummelin. Updated

[github-actions]

This pull request has merge conflicts that need to be resolved.

[emosbaugh]

@jnummelin i think we discussed backporting this to previous versions. is that something that will happen with the next release or something i can help with?