Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat kine data sources as URLs #4879

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Aug 21, 2024

Description

They aren't (necessarily) valid URLs, hence url.Parse is inappropriate. Introuduce the pkg/config/kine package to provide some utility functions.

Fixes:

Supersedes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
They aren't (necessarily) valid URLs, hence url.Parse is inappropriate.
Introuduce the pkg/config/kine package to provide some utility functions.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 marked this pull request as ready for review August 21, 2024 11:56
@twz123 twz123 requested a review from a team as a code owner August 21, 2024 11:56
@twz123 twz123 requested review from kke and jnummelin August 21, 2024 11:56
@fruworg fruworg mentioned this pull request Aug 22, 2024
2 tasks
@twz123 twz123 merged commit a25ce3c into k0sproject:main Aug 26, 2024
80 checks passed
@twz123 twz123 deleted the kine-dsn branch August 26, 2024 07:02
@twz123 twz123 linked an issue Aug 26, 2024 that may be closed by this pull request
4 tasks
@jnummelin jnummelin mentioned this pull request Aug 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of MySQL DSNs
2 participants