Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable BuildKit's InvalidDefaultArgInFrom build check #5374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable BuildKit's InvalidDefaultArgInFrom build check #5374

wants to merge 1 commit into from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 20, 2024

Description

The BUILDIMAGE argument has no default value by design, since it always comes from the Makefile. So disable the check.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Disable BuildKit's InvalidDefaultArgInFrom build check
e42ca53 
The BUILDIMAGE argument has no default value by design, since it always
comes from the Makefile. So disable the check.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added the chore label Dec 20, 2024
@twz123 twz123 marked this pull request as ready for review December 20, 2024 14:59
@twz123 twz123 requested review from a team as code owners December 20, 2024 14:59
@twz123 twz123 requested review from ncopa and jnummelin December 20, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123