Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panic() from builtin functions #1049

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Remove panic() from builtin functions #1049

merged 1 commit into from
Sep 27, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Sep 27, 2024

SSIA.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1049 (b2fa7a5) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,807,825,956 ns/op 4,105,996,918 ns/op 298,170,962 ns/op
Bytes allocated per iteration 1,785,711,936 B/op 1,786,033,008 B/op 321,072 B/op
Allocs per iteration 21,133,087 allocs/op 21,133,150 allocs/op 63 allocs/op
Metadata
main (-) #1049 (b2fa7a5)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1049 (b2fa7a5) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,800,243,560 ns/op 4,712,760,766 ns/op -87,482,794 ns/op
Bytes allocated per iteration 2,219,367,928 B/op 2,219,417,120 B/op 49,192 B/op
Allocs per iteration 30,869,031 allocs/op 30,874,078 allocs/op 5,047 allocs/op
Metadata
main (-) #1049 (b2fa7a5)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1049 (b2fa7a5) +/-
Number of iterations 19 16 -3
Nanoseconds per iteration 67,141,183 ns/op 65,733,614 ns/op -1,407,569 ns/op
Bytes allocated per iteration 60,121,615 B/op 60,132,656 B/op 11,041 B/op
Allocs per iteration 205,385 allocs/op 205,403 allocs/op 18 allocs/op
Metadata
main (-) #1049 (b2fa7a5)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

@k1LoW k1LoW changed the title Remove panic from builtin functions Remove panic() from builtin functions Sep 27, 2024
@k1LoW k1LoW removed the minor label Sep 27, 2024
Copy link
Contributor

Code Metrics Report

main (4db79a8) #1049 (b2fa7a5) +/-
Coverage 64.5% 64.4% -0.1%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 5m38s 5m46s +8s
Details
  |                     | main (4db79a8) | #1049 (b2fa7a5) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          64.5% |           64.4% | -0.1% |
  |   Files             |             77 |              77 |     0 |
  |   Lines             |           8695 |            8666 |   -29 |
- |   Covered           |           5609 |            5589 |   -20 |
+ | Code to Test Ratio  |          1:0.7 |           1:0.7 |  +0.0 |
  |   Code              |          15984 |           15941 |   -43 |
+ |   Test              |          11635 |           11663 |   +28 |
- | Test Execution Time |          5m38s |           5m46s |   +8s |

Code coverage of files in pull request scope (62.3% → 62.1%)

Files Coverage +/-
builtin/compare.go 75.0% 0.0%
builtin/diff.go 73.2% -0.1%
builtin/faker.go 13.4% 0.0%
builtin/merge.go 83.3% +3.3%
builtin/omit.go 66.6% -4.8%
builtin/pick.go 66.6% -4.8%
builtin/time.go 100.0% +11.1%
builtin/url.go 0.0% 0.0%
eval.go 82.3% -0.3%
option.go 58.9% +0.0%

Reported by octocov

@k1LoW k1LoW merged commit cf84781 into main Sep 27, 2024
8 checks passed
@k1LoW k1LoW deleted the fix-builtin branch September 27, 2024 06:17
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant