Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of unstable operation during OAS Spec verification #91

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

k2tzumi
Copy link
Collaborator

@k2tzumi k2tzumi commented Jul 31, 2022

Problem

When performing OAS Spec validation, the following error would occur in rare cases when submitting a request.

  • example
http request failed on ‘api test’.steps.oas: Put “http://localhost:8000/api/hoge/394336045384073216?date=202104”: http: ContentLength=591 with Body length 616

I couldn't reproduce it in the test code, but it looked like the request body object was being used all over again during validation.

Incidentally, the test scenario in which the problem occurred was reproducible, as it made extensive use of includes.

Contents of Proposal

It seems to be stable if request doby is reset after verifying OAS Spec but before sending actual request.

Fixed an error in the response definition of the OAS Spec (Github API) that was found when creating the test code.

@k2tzumi k2tzumi changed the title 🧪 use OpenApi3Validator. Fix open api validator Jul 31, 2022
@k2tzumi k2tzumi changed the title Fix open api validator [WIP] Fix open api validator Jul 31, 2022
@k2tzumi k2tzumi changed the title [WIP] Fix open api validator Improvement of unstable operation during OAS Spec verification Jul 31, 2022
@k1LoW k1LoW added the bug Something isn't working label Aug 1, 2022
@k1LoW
Copy link
Owner

k1LoW commented Aug 1, 2022

@k2tzumi Thank you!!!

@k1LoW k1LoW merged commit 72b6081 into k1LoW:main Aug 1, 2022
@k2tzumi k2tzumi deleted the fix-open-api-validator branch August 20, 2022 01:32
k2tzumi added a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants