Improvement of unstable operation during OAS Spec verification #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y and were becoming unstable.
k2tzumi
changed the title
|
@k2tzumi Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When performing OAS Spec validation, the following error would occur in rare cases when submitting a request.
I couldn't reproduce it in the test code, but it looked like the request body object was being used all over again during validation.
Incidentally, the test scenario in which the problem occurred was reproducible, as it made extensive use of includes.
Contents of Proposal
It seems to be stable if request doby is reset after verifying OAS Spec but before sending actual request.
Fixed an error in the response definition of the OAS Spec (Github API) that was found when creating the test code.