Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existing virtual relation strategies to the README #622

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

suzuki
Copy link
Contributor

@suzuki suzuki commented Oct 8, 2024

About

I found undocumented strategies: identical, identicalSingularTableName

tbls/config/naming.go

Lines 24 to 49 in 76d30f8

func SelectNamingStrategy(name string) (*NamingStrategy, error) {
switch name {
case "", "default":
// default
return &NamingStrategy{
ParentTable: defaultParentTableNamer,
ParentColumn: defaultParentColumnNamer,
}, nil
case "singularTableName":
return &NamingStrategy{
ParentTable: singularTableParentTableNamer,
ParentColumn: singularTableParentColumnNamer,
}, nil
case "identical":
return &NamingStrategy{
ParentTable: defaultParentTableNamer,
ParentColumn: identicalParentColumnNamer,
}, nil
case "identicalSingularTableName":
return &NamingStrategy{
ParentTable: singularTableParentTableNamer,
ParentColumn: identicalParentColumnNamer,
}, nil

I just wanted to use an identiacal strategy.

@k1LoW
Copy link
Owner

k1LoW commented Oct 8, 2024

@suzuki Thank you!!!

@k1LoW k1LoW merged commit eeab4ec into k1LoW:main Oct 8, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 6, 2024
@suzuki suzuki deleted the add-existing-strategies branch October 8, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants