feat(postgres): Ensure ordering of index columns is always stable #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
First of all, thanks for the great work on this project!
I use
tblswith Postgres in the CI pipeline of some services I work on in my daily job and I noticed that the order of the columns in multi-column indexes is not always stable. In particular, it can change across different Postgres versions because the query used to analyze the schema does not specify an order for the column names.This PR adds an
ORDER BY attr.attnum ASCclause to such query so that the column names are always returned in the same order for multi-column indexes. This order should match the actual definition of the index (even if I'm not 100% sure, as the official docs are not super clear about it 😅).Thanks!