Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcard in viewpoints[].tables: #643

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jan 17, 2025

Support * in viewpoints[].tables:

viewpoints:
  -
    name: post
    desc: for post
    tables:
      - 'post*'
  -
    name: administrator
    desc: administrator schema only
    tables:
      - 'administrator.*'

@k1LoW k1LoW added the enhancement New feature or request label Jan 17, 2025
@k1LoW k1LoW self-assigned this Jan 17, 2025
@k1LoW k1LoW changed the title Support wildcard in viewpoints[].tables Support wildcard in viewpoints[].tables: Jan 17, 2025
@k1LoW k1LoW force-pushed the viewpoint-support-schema branch from e0e1b52 to f541026 Compare January 17, 2025 06:17
@k1LoW k1LoW force-pushed the viewpoint-support-schema branch from 558d96f to f2cd79c Compare January 17, 2025 06:43
@k1LoW k1LoW force-pushed the viewpoint-support-schema branch from f2cd79c to a6b2295 Compare January 17, 2025 06:50
Copy link
Contributor

Code Metrics Report

main (a0a4f93) #643 (dbdb391) +/-
Coverage 55.9% 54.2% -1.7%
Code to Test Ratio 1:0.4 1:0.4 -0.1
Test Execution Time 3m39s 3m38s -1s
Details
  |                     | main (a0a4f93) | #643 (dbdb391) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          55.9% |          54.2% | -1.7% |
  |   Files             |             52 |             52 |     0 |
  |   Lines             |           4766 |           4775 |    +9 |
- |   Covered           |           2666 |           2591 |   -75 |
- | Code to Test Ratio  |          1:0.4 |          1:0.4 |  -0.1 |
  |   Code              |          10339 |          10358 |   +19 |
  |   Test              |           4342 |           4342 |     0 |
+ | Test Execution Time |          3m39s |          3m38s |   -1s |

Code coverage of files in pull request scope (63.7% → 63.1%)

Files Coverage +/-
config/config.go 64.0% 0.0%
drivers/postgres/postgres.go 81.8% 0.0%
schema/schema.go 39.8% -1.5%

Reported by octocov

@k1LoW k1LoW merged commit 77e97f5 into main Jan 17, 2025
4 checks passed
@k1LoW k1LoW deleted the viewpoint-support-schema branch January 17, 2025 07:10
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant