feat: enable c api for android ci #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! |
|
Will release a new version on the coming Sunday this week. |
|
hello, great work! |
|
thank you, sadly it still didn't work for me, i am trying to do an android build with unity, the moment i call the a function from the dll the app crashes (in an apk android build), do you have any idea why? |
|
please post error logs. otherwise, no one except you knows what is happening. |
|
that's the issue, the app quits, before leaving any log (only log before the the plugin functions is shown), at least that's what i observed from unity, i will see if i can get direct log using logcat |
|
so here is the logcat output: here is also the part of the code that calls that function (the crash happens when i call SherpaOnnxCreateOfflineTts but i assume it would be the same for the rest of the functions as well): plugins placement in unity: and their import settings (the same for the 3 .so files): i will be waiting for you reply or if you need further details, thank you! |
|
from the log Please check that the file is placed in the correct location. |
|
i see, the file is indeed placed correctly, but now i understand the problem, unity packs the location its in (StreamingAssets folder) differently in android, and IO operations won't be able to access it like that.. this is bad, i will need to find an alternative way to load the models on android |
Here is the log from sherpa-onnx. It shows you have indeed passed some parameters to sherpa-onnx's C API. Please pay attention to the path.
The C++ code uses I don't know what the meaning of |
Can you first copy the files from assets into disk? |
|
Or does unity provide C or C++ APIs to read files from assets? If so, we can change sherpa-onnx to support that as long as you can help to test the changes. |
|
i think it's possible using AndroidJavaClass class in unity, but the easiest way would be to copy the models into a readable location once on android, there is way to load such files in unity using UnityWebRequest, load them from the StreamingAssets location, and copy them somewhere differently (on a readable path), then i can pass the new path to the sherpa plugin, and this has to be done only the first time you open the apk, this is the best work-around usually, if you want i can provide the code i will write for that later :) |
|
Once it works for you, it would be great if you can post the code here so that others won't get the same issues. |
|
i am unsure about the espeak data path however, how is the plugin reading it? |
|
It is the same as the model, e.g., the same as tokens.txt Just copy the folder from the assets to some locations and pass the path to sherpa-onnx. |
|
By the way, you need to copy all the files from espeak-ng-data directory and you need to keep the structure of epseak-ng-data. espeak-ng-data also contains sub-directories. |
|
okay, working on it |
|
Good news! i got it to work, here is an apk to test, i will provide a cleaned version of the code involved later in the day, and hopefully make an asset store package after that with more automated features like voice models download and easy integration of sherpa-onnx in unity, having packages for this in game engines such as unity and unreal engine is the way to make this super project super popular! great work @csukuangfj! |
|
Thanks! |
|
question: is token.txt file common for all models, or does each model have a separate one? |
|
Good Morning, with this we will have a unity function that shows in the editor like this: Optionally we can make unity call this function automatically each time we do a build: now on the android side, the StreamingAssetsApi script contains functions to copy a file or a directory recursively from the streaming assets to different directory, along with function that use the hierarchy file to get a list of files in a certain directory or sub directory. the StreamingAssetsApi uses coroutines to handle the copy operations, which you can call using the StartCoroutine function in a MonoBehaviour script, but also has an async await wrapper functions for this to run the coroutines using an awaitable RunCoroutine Function, for example:
now that we have the streamingAssetsApi implemented, we can test the sherpa-onnx tts at runtime using the following script: now you need to fill the inspector values: the important ones are the paths, make sure to provide the paths relative to the streamingAssets Folder. and make sure that those files actually exist.
if you have a different work around for the streaming assets issue, i'd be happy to hear it :) |
Thank you for sharing the detailed solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1634