fix: preserve coredns config during cluster restart using the coredns-custom configmap (!) #1453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fixes #1221
Why
Since
coredns
configmap will be reverted to original state during k3s startup process, this PR utilizescoredns-custom
configmap (introduced in k3s-io/k3s#4397) to persistent custom coredns configs (e.g. thehost.k3d.internal
record).Since coredns's
host
plugin can only be used once per server block, I have to use thefile
plugin.A go template is used to render the configmap. I don't know if there's a better way.
Implications
Not I'm aware of.