InViewportDirective should emit when the host element is destroyed

[tinesoft]

Hi,

First of all, thanks for this useful library.

We came across an edge case with inViewportAction event from the inViewportDirective : It will NOT be emitted when the hosting component is destroyed.... thus failing to notify the "listeners" of that event, that the element is no longer visible, because destroyed/removed from the DOM...

We think, this line:

this.emitAction(undefined, false);

should be called, after this line:

ng-in-viewport/projects/ng-in-viewport/src/lib/directives/in-viewport.directive.ts

Line 83 in 1565794

this.inViewportService.unregister(this.nativeElement, this.config);

I can provide a PR with the fix if you agree

[k3nsei]

Happy to hear nice words.

Could you provide example scenario in https://stackblitz.com/ ??

[tinesoft]

Happy to hear nice words.

Sure! well deserved!

Could you provide example scenario in stackblitz.com ??

https://ng-in-viewport-gb-ex-1-vsec6f.stackblitz.io

It was derived from the one from the docs.
Open the console to see the expected behavior
I use the "Remove Item" button simulate an item being destroyed.
I would expect to see "target: 'Item X' is visible: false" in the console, when removing the item...

[k3nsei]

@tinesoft could you confirm that proposed solution in #1419 is what you are expecting?

[k3nsei]

@all-contributors
please add @tinesoft for ideas
please add @tinesoft for review

[allcontributors]

@k3nsei

I've put up a pull request to add @tinesoft! 🎉

[tinesoft]

Thanks for the very fast ⚡ reply/action @k3nsei !

As a fellow OSS maintainer , I appreciate and value this ^^