Add create-namespace support #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
create_namespace
branch
3 times, most recently
from
2b7c114 to
d6349af
Compare
This also fixes the tests to ensure that charts are deleted at the end of each context; previously it would leave the test cluster dirty as the test charts were left behind, preventing the test namespace from deleting properly. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
create_namespace
branch
from
d6349af to
eee7f86
Compare
briandowns
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the tests to ensure that charts are deleted at the end of each context; previously it would leave the test cluster dirty as the HelmChart resources were left behind at the end of each tests, preventing the test namespace from deleting properly.
Linked Issues