Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.28] fix typo, use rancher/permissions #10299

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

HarrisonWAffel
Copy link
Contributor

Proposed Changes

Fixes a typo in config.go and removes the windows specific ACL logic in favor of the rancher/permissions library. The logic in acl/acl_windows.go was taken directly from rancher/permissions, so there is no functional difference, this is simply addressing tech debt.

Types of Changes

Bugfix

Verification

Create a Windows cluster and ensure the proper ACL is set

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

Signed-off-by: Harrison Affel <harrisonaffel@gmail.com>
@HarrisonWAffel HarrisonWAffel requested a review from a team as a code owner June 5, 2024 15:49
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (7de7adb) to head (7b44c91).
Report is 3 commits behind head on release-1.28.

Files Patch % Lines
pkg/agent/config/config.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #10299      +/-   ##
================================================
- Coverage         42.68%   36.36%   -6.33%     
================================================
  Files               163      160       -3     
  Lines             16632    14051    -2581     
================================================
- Hits               7099     5109    -1990     
+ Misses             8274     7948     -326     
+ Partials           1259      994     -265     
Flag Coverage Δ
e2etests 36.36% <0.00%> (-9.56%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit b261f29 into k3s-io:release-1.28 Jun 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants