Fix updatecli config for klipper and helm-controller

[manuelbuil]

Proposed Changes

Modify the updatecli config so that it updates the version based on latest tag and not based on date

Types of Changes

Bugfix

Verification

Wait for the script to be executed by updatecli in the next run

Testing

Linked Issues

User-Facing Change

Further Comments

[macedogm]

FYI I'm testing locally, as I believe that there is another way to do the same directly with Updatecli syntax.

[macedogm]

I tested locally and I believe that Updatecli's actual behavior is right. The problem is that we are using the wrong filter. Probably my fault when I first proposed this automation.

The versionfilter in the following lines:

k3s/updatecli/updatecli.d/klipper-helm-and-controller.yaml

Lines 49 to 50 in 62caa4a

	versionfilter:
	kind: "latest"

k3s/updatecli/updatecli.d/klipper-helm-and-controller.yaml

Lines 59 to 60 in 62caa4a

	versionfilter:
	kind: "latest"

Is getting the latest version based on the date:

We should actually use typefilter to look for the latest tag.

diff --git a/updatecli/updatecli.d/klipper-helm-and-controller.yaml b/updatecli/updatecli.d/klipper-helm-and-controller.yaml
index e62e9cb..52456fe 100644
--- a/updatecli/updatecli.d/klipper-helm-and-controller.yaml
+++ b/updatecli/updatecli.d/klipper-helm-and-controller.yaml
@@ -46,8 +46,8 @@ sources:
       repository: "{{ .helm_controller.repo }}"
       branch: "{{ .helm_controller.branch }}"
       token: "{{ requiredEnv .github.token }}"
-      versionfilter:
-        kind: "latest"
+      typefilter:
+        latest: true
   klipper-helm:
     name: "Get Klipper Helm latest release version"
     kind: "githubrelease"
@@ -56,8 +56,8 @@ sources:
       repository: "{{ .klipper_helm.repo }}"
       branch: "{{ .klipper_helm.branch }}"
       token: "{{ requiredEnv .github.token }}"
-      versionfilter:
-        kind: "latest"
+      typefilter:
+        latest: true
   get-pwd:
     name: "Run Updatecli execution directory"
     kind: "shell"

With this change we can drop the fix that you proposed and use Updatecli's proper syntax.

[manuelbuil]

I tested locally and I believe that Updatecli's actual behavior is right. The problem is that we are using the wrong filter. Probably my fault when I first proposed this automation.

The versionfilter in the following lines:

k3s/updatecli/updatecli.d/klipper-helm-and-controller.yaml

Lines 49 to 50 in 62caa4a

	versionfilter:
	kind: "latest"

k3s/updatecli/updatecli.d/klipper-helm-and-controller.yaml

Lines 59 to 60 in 62caa4a

	versionfilter:
	kind: "latest"

Is getting the latest version based on the date:

We should actually use typefilter to look for the latest tag.

diff --git a/updatecli/updatecli.d/klipper-helm-and-controller.yaml b/updatecli/updatecli.d/klipper-helm-and-controller.yaml
index e62e9cb..52456fe 100644
--- a/updatecli/updatecli.d/klipper-helm-and-controller.yaml
+++ b/updatecli/updatecli.d/klipper-helm-and-controller.yaml
@@ -46,8 +46,8 @@ sources:
       repository: "{{ .helm_controller.repo }}"
       branch: "{{ .helm_controller.branch }}"
       token: "{{ requiredEnv .github.token }}"
-      versionfilter:
-        kind: "latest"
+      typefilter:
+        latest: true
   klipper-helm:
     name: "Get Klipper Helm latest release version"
     kind: "githubrelease"
@@ -56,8 +56,8 @@ sources:
       repository: "{{ .klipper_helm.repo }}"
       branch: "{{ .klipper_helm.branch }}"
       token: "{{ requiredEnv .github.token }}"
-      versionfilter:
-        kind: "latest"
+      typefilter:
+        latest: true
   get-pwd:
     name: "Run Updatecli execution directory"
     kind: "shell"

With this change we can drop the fix that you proposed and use Updatecli's proper syntax.

Thanks Gui

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.64%. Comparing base (0c29696) to head (dfd247e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0c29696) and HEAD (dfd247e). Click for more details.

HEAD has 18 uploads less than BASE

Flag	BASE (0c29696)	HEAD (dfd247e)
inttests	11	0
e2etests	7	0

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #11290       +/-   ##
===========================================
- Coverage   46.97%   13.64%   -33.33%     
===========================================
  Files         179      176        -3     
  Lines       18587    18513       -74     
===========================================
- Hits         8731     2527     -6204     
- Misses       8497    15684     +7187     
+ Partials     1359      302     -1057     

Flag	Coverage Δ
e2etests	?
inttests	?
unittests	13.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.