Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to the output command to be consistent with the product command #11345

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

xandradx
Copy link
Contributor

Proposed Changes

The final instructions always makes reference to k3s, it should make reference to the command according to the PRODUCT in use k3s or rke2

Types of Changes

Change text in:

To update certificates, you may now run:

Use ${PRODUCT} not hard coded k3s

Verification

Minor change

Testing

Minor change

User-Facing Change

NONE


Further Comments

This is a simple change but ensures consistency throughout the script and prevents potential confusion for the user.

@xandradx xandradx requested a review from a team as a code owner November 19, 2024 23:44
@brandond
Copy link
Member

Please sign-off your commit for DCO

Signed-off-by: Jorge Andrade <jandrade@i-t-m.com>
Copy link
Member

@cwayne18 cwayne18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.26%. Comparing base (59707da) to head (6ff1222).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11345      +/-   ##
==========================================
+ Coverage   34.63%   42.26%   +7.62%     
==========================================
  Files         162      179      +17     
  Lines       18010    18600     +590     
==========================================
+ Hits         6238     7861    +1623     
+ Misses      10606     9535    -1071     
- Partials     1166     1204      +38     
Flag Coverage Δ
e2etests 33.95% <ø> (?)
inttests 34.73% <ø> (+0.09%) ⬆️
unittests 13.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@brandond brandond merged commit 4fef655 into k3s-io:master Nov 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants