-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker check warnings #11474
Merged
Merged
Fix docker check warnings #11474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11474 +/- ##
==========================================
- Coverage 47.87% 43.22% -4.66%
==========================================
Files 181 181
Lines 18794 18794
==========================================
- Hits 8998 8124 -874
- Misses 8448 9470 +1022
+ Partials 1348 1200 -148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Dec 18, 2024
cwayne18
approved these changes
Dec 18, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Jan 13, 2025
dereknola
added a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Internal Build
Verification
docker build . --check -f Dockerfile.local
docker build . --check -f Dockerfile.test
Testing
Linked Issues
N/A
User-Facing Change
Further Comments
I finally broke down and got annoyed enough about these useless warnings.