fix checkError in terraform/testutils #5893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
dereknola
approved these changes
Aug 3, 2022
|
@Abirdcfly Thanks for your community PR. I will get this merged into the August release once another reviewer approves. |
brandond
approved these changes
Aug 3, 2022
briandowns
approved these changes
Aug 3, 2022
|
Kindly ping @dereknola for merge, thanks. |
dereknola
pushed a commit
to dereknola/k3s
that referenced
this pull request
Sep 1, 2022
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
dereknola
pushed a commit
to dereknola/k3s
that referenced
this pull request
Sep 1, 2022
Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Derek Nola <derek.nola@suse.com>
nikolaishields
pushed a commit
to nikolaishields/k3s
that referenced
this pull request
Sep 14, 2022
Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Nikolai Shields <nikolai@nikolaishields.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abirdcfly fp544037857@gmail.com
Proposed Changes
log.Fatalhttps://cs.opensource.google/go/go/+/refs/tags/go1.18.4:src/log/log.go;l=364-367;drc=2580d0e08d5e9f979b943758d3c49877fb2324cb is equivalent to Print() followed by a call to os.Exit(1). So nopanicneeded.Also I think this function wants to output the error in the function parameter to the log
Types of Changes
Bugfix
Verification
Testing
Linked Issues
User-Facing Change
Further Comments