-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add format command on Makefile #7437
Conversation
f321b38
to
29b4d17
Compare
Makefile
Outdated
@@ -1,4 +1,6 @@ | |||
TARGETS := $(shell ls scripts | grep -v \\.sh) | |||
GO_FILES ?= $$(find . -name '*.go' | grep -v vendor | grep -v generated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we don't have a vendor
folder for k3s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if someone use make deps
it generates one
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7437 +/- ##
===========================================
+ Coverage 19.45% 47.61% +28.16%
===========================================
Files 81 140 +59
Lines 5495 14323 +8828
===========================================
+ Hits 1069 6820 +5751
- Misses 4204 6421 +2217
- Partials 222 1082 +860
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
29b4d17
to
3b6f84d
Compare
This commit adds the format command to make it easier to be compliant to golangci-lint issues Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
3b6f84d
to
abde5fe
Compare
This commit adds the format command to make it easier to be compliant to golangci-lint issues
Proposed Changes
This commit adds the format command to make it easier to be compliant to golangci-lint issues.
I would prefer to use the flag -local for goimports that will segregate imports by:
will look something like this:
but by applying this almost all files will be affected, so maybe apply this change and then another to improve.
Types of Changes
New feature
Verification
make format
Testing
Linked Issues
User-Facing Change
Further Comments