Test Coverage Reports for E2E tests #7526
Conversation
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7526 +/- ##
===========================================
+ Coverage 19.86% 51.97% +32.11%
===========================================
Files 81 141 +60
Lines 7607 14327 +6720
===========================================
+ Hits 1511 7447 +5936
+ Misses 5870 5708 -162
- Partials 226 1172 +946
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
| @@ -765,6 +768,25 @@ steps: | |||
| - name: cache | |||
| path: /tmp/artifacts | |||
|
|
|||
| - name: upload to codecov | |||
| image: robertstettner/drone-codecov | |||
There was a problem hiding this comment.
I love images that just are just from some dude.
Does this have a project somewhere, or should we consider mirroring or building it ourselves into an org we can trust?
There was a problem hiding this comment.
I swear this is the De Facto plugin for CodeCov in Drone. If you go looking at drone plugins, its the only one https://plugins.drone.io/?search=codecov. The source files are here https://github.com/robertstettner/drone-codecov. Codecov documentation sends to a 404 non existent Drone plugin https://about.codecov.io/tool/drone/. Longhorn is currently using this plugin.
There was a problem hiding this comment.
the repo hasn't been touched in 6 years, is the image also that old!?
There was a problem hiding this comment.
It looks like it's also just a simple wrapper around the deprecated bash uploader
https://github.com/robertstettner/drone-codecov/blob/master/Dockerfile#L4
I wonder if we should just toss together a proper plugin that uses the new one from https://docs.codecov.com/docs/codecov-uploader
There was a problem hiding this comment.
I'll open a future PR to move to directly uploading via their bash tool
There was a problem hiding this comment.
no, bash is bad, we want to use the new non-bash one.
Signed-off-by: Derek Nola <derek.nola@suse.com>
* Move coverage writer into agent and server * Add coverage report to E2E PR tests * Add codecov upload to drone Signed-off-by: Derek Nola <derek.nola@suse.com>
Proposed Changes
go testto latest stable releaseTypes of Changes
E2E
Verification
Drone CI passes, see increase in coverage report https://app.codecov.io/gh/k3s-io/k3s/pull/7526
Testing
Its all testing
Linked Issues
N/A
User-Facing Change
Further Comments