-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a k3s data directory location specified by the cli #7791
Conversation
Need to add a cli flag for this. Also, should probably have config file loading support for the certificate commands. Signed-off-by: leilei.zhai <leilei.zhai@qingteng.cn>
Because the demand is urgent, so I plan to try to modify it myself. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7791 +/- ##
==========================================
+ Coverage 47.14% 51.51% +4.37%
==========================================
Files 143 143
Lines 14509 14509
==========================================
+ Hits 6840 7475 +635
+ Misses 6580 5849 -731
- Partials 1089 1185 +96
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is perfect!
This is wonderful, thank you so much for the PR! Nothing better than seeing community members fix issues that bother them :) We'll get this merged in as soon as we're out of code freeze and it should be good to go in the July patches, thanks again! |
Need to add a cli flag for this. Also, should probably have config file loading support for the certificate commands. Signed-off-by: leilei.zhai <leilei.zhai@qingteng.cn> (cherry picked from commit 72d50b1) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Need to add a cli flag for this. Also, should probably have config file loading support for the certificate commands. Signed-off-by: leilei.zhai <leilei.zhai@qingteng.cn> (cherry picked from commit 72d50b1) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Need to add a cli flag for this. Also, should probably have config file loading support for the certificate commands. Signed-off-by: leilei.zhai <leilei.zhai@qingteng.cn> (cherry picked from commit 72d50b1) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Need to add a cli flag for this. Also, should probably have config file loading support for the certificate commands. Signed-off-by: leilei.zhai <leilei.zhai@qingteng.cn> (cherry picked from commit 72d50b1) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Need to add a cli flag for this. Also, should probably have config file loading support for the certificate commands. Signed-off-by: leilei.zhai <leilei.zhai@qingteng.cn> (cherry picked from commit 72d50b1) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Need to add a cli flag for this. Also, should probably have config file loading support for the certificate commands. Signed-off-by: leilei.zhai <leilei.zhai@qingteng.cn> (cherry picked from commit 72d50b1) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Proposed Changes
Add a cli to specify the self-holding of the k3s certificate rotate-ca command for the k3s custom data directory
Types of Changes
Just add a cli to cert.go, specifying the k3s data directory location with the --data-dir parameter
Verification
Because the installation and compilation process of the compilation environment took too long, I only chose to compile and test on the server of amd64. The test results are as follows:
Testing
Linked Issues
#7774
User-Facing Change
Further Comments
I don't know much about golang, so I just looked for the logic of rotating certificates, not sure if there are other problems