Warn that v1.28 will deprecate reencrypt/prepare

[dereknola]

Proposed Changes

The new secrets-encrypt rework (see #7760) will be introduced in v1.28, and the prepare and reencrypt will no longer be used (its all covered in the single rotate command). This adds warning to those 2 commands.

Types of Changes

CLI Warning

Verification

Testing

Linked Issues

#7760
#7297

User-Facing Change

Further Comments

[brandond]

So the plan would be to deprecate this this in 1.28, and remove it in 1.30? Since we aim for a two-minor notice period on removals?

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +4.36 🎉

Comparison is base (ce3443d) 47.13% compared to head (241d4e2) 51.49%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7848      +/-   ##
==========================================
+ Coverage   47.13%   51.49%   +4.36%     
==========================================
  Files         143      143              
  Lines       14513    14517       +4     
==========================================
+ Hits         6841     7476     +635     
+ Misses       6580     5850     -730     
- Partials     1092     1191      +99     

Flag	Coverage Δ
e2etests	49.30% <100.00%> (?)
inttests	44.52% <50.00%> (+0.02%)	⬆️
unittests	19.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cli/secretsencrypt/secrets_encrypt.go	47.12% <100.00%> (+5.26%)	⬆️
pkg/server/secrets-encrypt.go	42.75% <100.00%> (+42.04%)	⬆️

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dereknola]

I think this is going to be a much shorter depreciation, because we aren't really getting rid of it, the feature is getting consolidated into a single command.

[brandond]

I think we still need to follow the 2-minor CLI deprecation schedule. Our CLI is essentially our API contract with other projects; we can't break things without sufficient notice even if it is part of feature consolidation.