-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry for clone step #7862
Add retry for clone step #7862
Conversation
Signed-off-by: Johnatas <johnatas.santos@suse.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7862 +/- ##
==========================================
+ Coverage 47.08% 51.61% +4.53%
==========================================
Files 143 143
Lines 14524 14524
==========================================
+ Hits 6839 7497 +658
+ Misses 6593 5844 -749
- Partials 1092 1183 +91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johnatas <johnatas.santos@suse.com>
Is this necessary? If the clone steps fails, there is likely a GitHub outage that will require a re-run of CI pipelines due to other subsequent failures. |
@brandond Implementing retries for the clone step in CI pipelines can help address temporary network issues, mitigate false failures, and increase overall pipeline stability. While it may not immediately resolve broader issues like a GitHub outage, retrying the clone step increases the chances of successful pipeline execution and contributes to reliable results. What do you think ? |
Other than github outages, have we had sufficient problems with the clone step that make this necessary? |
The repeated issues were what inspired the effort. Has happened a number of times with rke2 and k3s over the last few releases but we're overlooked chalking it up to anomalous behavior. This is also part of the effort for more automation and to remove the need for unnecessary manual intervention when a restart is all that's needed. |
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments