Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry for clone step #7862

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Add retry for clone step #7862

merged 2 commits into from
Jul 7, 2023

Conversation

johnatasr
Copy link
Contributor

@johnatasr johnatasr commented Jul 4, 2023

Proposed Changes

  • Added a retry settings for clone step, allowing repeat the process three times.

Types of Changes

  • Drone CI

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Johnatas <johnatas.santos@suse.com>
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.53 🎉

Comparison is base (882297b) 47.08% compared to head (b1fe26b) 51.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7862      +/-   ##
==========================================
+ Coverage   47.08%   51.61%   +4.53%     
==========================================
  Files         143      143              
  Lines       14524    14524              
==========================================
+ Hits         6839     7497     +658     
+ Misses       6593     5844     -749     
- Partials     1092     1183      +91     
Flag Coverage Δ
e2etests 49.42% <ø> (?)
inttests 44.49% <ø> (+0.04%) ⬆️
unittests 19.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnatasr johnatasr marked this pull request as ready for review July 4, 2023 18:58
@johnatasr johnatasr requested a review from a team as a code owner July 4, 2023 18:58
Signed-off-by: Johnatas <johnatas.santos@suse.com>
@brandond
Copy link
Member

brandond commented Jul 5, 2023

Is this necessary? If the clone steps fails, there is likely a GitHub outage that will require a re-run of CI pipelines due to other subsequent failures.

@johnatasr
Copy link
Contributor Author

@brandond Implementing retries for the clone step in CI pipelines can help address temporary network issues, mitigate false failures, and increase overall pipeline stability. While it may not immediately resolve broader issues like a GitHub outage, retrying the clone step increases the chances of successful pipeline execution and contributes to reliable results. What do you think ?

@brandond
Copy link
Member

brandond commented Jul 6, 2023

Other than github outages, have we had sufficient problems with the clone step that make this necessary?

@briandowns
Copy link
Contributor

The repeated issues were what inspired the effort. Has happened a number of times with rke2 and k3s over the last few releases but we're overlooked chalking it up to anomalous behavior. This is also part of the effort for more automation and to remove the need for unnecessary manual intervention when a restart is all that's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants