[ADR] Server token rotation #8215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
|
@Oats87 @jakefhyde Heads up for potential future v2 prov work. This doesn't change any existing CLI, its only additive |
Signed-off-by: Derek Nola <derek.nola@suse.com>
Oats87
reviewed
Sep 1, 2023
There was a problem hiding this comment.
At a high level, this looks great.
I do have a few questions/comments on the implementation side:
- Can we ensure that there is a method to retrieve the outputs of the various subcommands for
tokeninjsonformat? This would greatly help with automation/reliable parsing of status. - How will this work with the config file parser? Considering if you pass in
tokenetc. into the config file, that gets "parsed" and rendered into the CLI. I would say it's likely a user can accidentally run into a situation where they are rotating the token and mismatching tokens. Perhaps the CLI should parse in the config file(s) and make sure that the old token isn't referenced anymore -- I expect that we will pave a new config file onto disk with the new token before/during our usage ofk3s token rotatewith CAPR. - Does K3s encrypt bootstrap data? If so, does this mean that etcd snapshots taken with the older token are no longer able to be restored?
brandond
requested changes
Sep 1, 2023
briandowns
approved these changes
Sep 13, 2023
galal-hussein
approved these changes
Sep 13, 2023
brandond
approved these changes
Sep 25, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ADR for Server Token Rotation
Linked Issues
rancher/rke2#2141
User-Facing Change
Further Comments