Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error when cluster reset while using server flag #8385

Merged

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Sep 19, 2023

Proposed Changes

Handle when the user tries to --cluster-reset when using the --server flag

Types of Changes

Handling Error

Verification

k3s server --server 11.22.33.44 --cluster-reset

Testing

Linked Issues

User-Facing Change

The user will receive a error when --cluster-reset with the --server flag

Further Comments

@vitorsavian vitorsavian requested a review from a team as a code owner September 19, 2023 17:08
pkg/cli/server/server.go Outdated Show resolved Hide resolved
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian force-pushed the add-cluster-reset-error-server-flag branch from a64e5f2 to 4c409c9 Compare September 25, 2023 17:41
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cae8b2b) 44.66% compared to head (9dd5f71) 51.50%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8385      +/-   ##
==========================================
+ Coverage   44.66%   51.50%   +6.83%     
==========================================
  Files         143      143              
  Lines       14746    15232     +486     
==========================================
+ Hits         6587     7845    +1258     
+ Misses       7119     6168     -951     
- Partials     1040     1219     +179     
Flag Coverage Δ
e2etests 48.72% <84.61%> (?)
inttests 44.77% <50.00%> (+2.81%) ⬆️
unittests 19.84% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/daemons/executor/executor.go 57.81% <ø> (ø)
pkg/etcd/etcd.go 44.88% <100.00%> (+9.20%) ⬆️
pkg/cli/server/server.go 59.25% <0.00%> (+4.39%) ⬆️

... and 48 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit b6ab24c into k3s-io:master Sep 26, 2023
15 checks passed
@vitorsavian vitorsavian deleted the add-cluster-reset-error-server-flag branch October 18, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants