Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-router package in build script #8630

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Oct 13, 2023

Proposed Changes

Package was changed in version script in bc332ac but we missed changing it here as well.

Both should have been changed when we updated kube-router to v2 for dual-stack support.

Types of Changes

bugfix

Verification

INFO[0016] Starting the netpol controller version v2.0.0-20230925161250-364f994b140b, built on 2023-10-13T19:55:29Z, go1.20.8

Testing

Linked Issues

User-Facing Change


Further Comments

Package was changed in version script in bc332ac but we missed changing it here as well.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner October 13, 2023 20:02
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@brandond
Copy link
Contributor Author

S390x is having issues, all other tests are passing. Merging.

@brandond brandond merged commit 7bb4a82 into k3s-io:master Oct 13, 2023
13 of 14 checks passed
@brandond brandond deleted the fix-kube-router-version branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants