Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonexistent dependency repositories #9213

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Jan 10, 2024

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

If starting with a cleaned mod cache, and direct proxy, 2 dependency chains are broken in K3s.
Fix the following:

go: github.com/Microsoft/hcsshim@v0.11.4 requires
	github.com/open-policy-agent/opa@v0.42.2 requires
	oras.land/oras-go@v1.2.0 requires
	github.com/distribution/distribution/v3@v3.0.0-20220526142353-ffbd94cbe269 requires
	github.com/mitchellh/osext@v0.0.0-20151018003038-5e2d6d41470f: invalid version: git ls-remote -q origin in /home/derek/go/pkg/mod/cache/vcs/94ed57c5b21c953d93b47487113db43a5c9b69fd990329ec70dc77348c4dd443: exit status 128:
	remote: Repository not found.
	fatal: repository 'https://github.com/mitchellh/osext/' not found

  • mitchellh has been warning that osext should no be used for 9 years and finally deleted the repo. hcsshim has still not updated opa to anything newer than v0.42.2 from July 2022. I opened an issue Update open-policy-agent dependency microsoft/hcsshim#1990, but until that gets addressed we can pin.

Also fix:

go: github.com/francoispqt/gojay@v1.2.13 requires
	cloud.google.com/go@v0.37.0 requires
	golang.org/x/build@v0.0.0-20190111050920-041ab4dc3f9d requires
	sourcegraph.com/sourcegraph/go-diff@v0.5.0: unrecognized import path "sourcegraph.com/sourcegraph/go-diff": reading https://sourcegraph.com/sourcegraph/go-diff?go-get=1: 404 Not Found

sourcegraph no longer hosts go-diff itself, it is now a github repo. Pinned to the latest (and likely last) version of v0.6.0 from Sept 2020

Types of Changes

Verification

Set go proxy to direct: go env -w GOPROXY=direct
Clean mod cache: go clean -modcache
Run go mod tidy

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner January 10, 2024 20:54
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6072476) 45.14% compared to head (3f7feb8) 40.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9213      +/-   ##
==========================================
- Coverage   45.14%   40.34%   -4.81%     
==========================================
  Files         154      154              
  Lines       16519    16519              
==========================================
- Hits         7458     6664     -794     
- Misses       7853     8712     +859     
+ Partials     1208     1143      -65     
Flag Coverage Δ
e2etests ?
inttests 37.63% <ø> (-0.04%) ⬇️
unittests 14.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants