Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcd snapshot reconcile for agentless servers #9809

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Mar 27, 2024

Proposed Changes

Fix etcd snapshot reconcile for agentless servers

Disable cleanup of orphaned snapshots and patching of node annotations if running agentless

Fixes regression in agentless etcd behavior introduced by #8064

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

Disable cleanup of orphaned snapshots and patching of node annotations if running agentless

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner March 27, 2024 21:56
@brandond brandond changed the title Fix etcd snapshot reconcile for agentless nodes Fix etcd snapshot reconcile for agentless servers Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 46.69%. Comparing base (c47c85e) to head (9513070).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/etcd/snapshot_controller.go 0.00% 11 Missing ⚠️
pkg/etcd/snapshot.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9809      +/-   ##
==========================================
- Coverage   51.56%   46.69%   -4.87%     
==========================================
  Files         155      155              
  Lines       13597    13611      +14     
==========================================
- Hits         7011     6356     -655     
- Misses       5262     6033     +771     
+ Partials     1324     1222     -102     
Flag Coverage Δ
e2etests 39.11% <7.14%> (-10.27%) ⬇️
inttests 39.44% <7.14%> (?)
unittests 16.38% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit edb0440 into k3s-io:master Mar 27, 2024
26 checks passed
@brandond brandond deleted the fix-snapshot-disable-agent branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants