Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split dnsupdate into provider pattern #255

Closed
kuritka opened this issue Jan 14, 2021 · 0 comments
Closed

Split dnsupdate into provider pattern #255

kuritka opened this issue Jan 14, 2021 · 0 comments
Assignees
@kuritka
Labels
refactoring
Milestone
0.8

Comments

@kuritka
Copy link
Collaborator

kuritka commented Jan 14, 2021 •
edited
Loading

  • Extract functionality into providers
  • clean dnsupdate
  • Extract metrics from controller
  • consider moving utility into AbsaOSS/gopg
@kuritka kuritka added this to the 0.8 milestone Jan 14, 2021
@kuritka kuritka self-assigned this Jan 14, 2021
kuritka added a commit that referenced this issue Jan 14, 2021
@kuritka
Related to #255
51cd8c8 
This is first of PR

 -  move Dig to utils
 -  move prettyPrint to utils and rename to `ToJSON()`
 -  cover `ToJSON()` by tests
 -  move environment variable `POD_NAMESPACE` to `depresolver`
 -  extend depresolver tests
 -  extend depresolver validators for namespace validator
 -  Extract Prometheus metrics into standalone module
 -  Extend prometheus metrics
 -  Fix controller tests
 -  remove dead registry/k3s.yaml file (pushed by mistake)

TODO:
  - dnsupdate refactor to provider pattern in next PR
  - fianally, some of utils will go into [gopkg](https://github.com/AbsaOSS/gopkg)
  - IMetrics introduction (#124)
kuritka added a commit that referenced this issue Jan 14, 2021
@kuritka
Related to #255
877167a 
This is first of PR

 -  move Dig to utils
 -  move prettyPrint to utils and rename to `ToJSON()`
 -  cover `ToJSON()` by tests
 -  move environment variable `POD_NAMESPACE` to `depresolver`
 -  extend depresolver tests
 -  extend depresolver validators for namespace validator
 -  Extract Prometheus metrics into standalone module
 -  Extend prometheus metrics
 -  Fix controller tests
 -  remove dead registry/k3s.yaml file (pushed by mistake)

TODO:
  - dnsupdate refactor to provider pattern in next PR
  - fianally, some of utils will go into [gopkg](https://github.com/AbsaOSS/gopkg)
  - IMetrics introduction (#124)
kuritka added a commit that referenced this issue Jan 14, 2021
@kuritka
Related to #255
db8bf54 
This is first of PR

 -  move Dig to utils
 -  move prettyPrint to utils and rename to `ToJSON()`
 -  cover `ToJSON()` by tests
 -  move environment variable `POD_NAMESPACE` to `depresolver`
 -  extend depresolver tests
 -  extend depresolver validators for namespace validator
 -  Extract Prometheus metrics into standalone module
 -  Extend prometheus metrics
 -  Fix controller tests
 -  remove dead registry/k3s.yaml file (pushed by mistake)

TODO:
  - dnsupdate refactor to provider pattern in next PR
  - fianally, some of utils will go into [gopkg](https://github.com/AbsaOSS/gopkg)
  - IMetrics introduction (#124)
@kuritka kuritka mentioned this issue Jan 14, 2021
Merged
kuritka added a commit that referenced this issue Jan 15, 2021
@kuritka
Related to #255
7a83bea 
This is first of PR

 -  move Dig to utils
 -  move prettyPrint to utils and rename to `ToJSON()`
 -  cover `ToJSON()` by tests
 -  move environment variable `POD_NAMESPACE` to `depresolver`
 -  extend depresolver tests
 -  extend depresolver validators for namespace validator
 -  Extract Prometheus metrics into standalone module
 -  Extend prometheus metrics
 -  Fix controller tests
 -  remove dead registry/k3s.yaml file (pushed by mistake)

TODO:
  - dnsupdate refactor to provider pattern in next PR
  - fianally, some of utils will go into [gopkg](https://github.com/AbsaOSS/gopkg)
  - IMetrics introduction (#124)
kuritka added a commit that referenced this issue Jan 15, 2021
@kuritka
Related to #255
d4c9f8b 
This is first of PR

 -  move environment variable `POD_NAMESPACE` to `depresolver`
 -  extend depresolver tests
 -  extend depresolver validators for namespace validator
 -  Extract Prometheus metrics into standalone module
 -  Extend prometheus metrics
 -  Fix controller tests
 -  remove dead registry/k3s.yaml file (pushed by mistake)

TODO:
  - dnsupdate refactor to provider pattern in next PR
  - fianally, some of utils will go into [gopkg](https://github.com/AbsaOSS/gopkg)
  - IMetrics introduction (#124)
kuritka added a commit that referenced this issue Jan 15, 2021
@kuritka
Related to #255
c761843 
This is first of PR

 -  move environment variable `POD_NAMESPACE` to `depresolver`
 -  extend depresolver tests
 -  extend depresolver validators for namespace validator
 -  Extract Prometheus metrics into standalone module
 -  Extend prometheus metrics
 -  Fix controller tests
 -  remove dead registry/k3s.yaml file (pushed by mistake)

TODO:
  - dnsupdate refactor to provider pattern in next PR
  - fianally, some of utils will go into [gopkg](https://github.com/AbsaOSS/gopkg)
  - IMetrics introduction (#124)
@kuritka kuritka mentioned this issue Jan 15, 2021
Merged
kuritka added a commit that referenced this issue Feb 1, 2021
@kuritka
related to #255
c9b6656 
Infoblox admin complains that tremendous amount of requests is killing his poor Infoblox UI.
Within Infoblox connection I found two other properties, which can be parametrised:
 - HTTPPoolConnections
 - HTTPRequestTimeout

For that purpose I made following steps:

 - update infoblox connection within infoblox provider
 - introduce new variables to `depresolver` with default values
 - update depresolver tests
 - update controller tests
 - introduce new variables in `operator.yaml`
 - `infoblox-cm.yaml` and `values.yaml` (demonstrative purpose, the default values can be injected by `depresolver`)
@kuritka kuritka mentioned this issue Feb 1, 2021
Merged
@kuritka kuritka closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuritka kuritka

Labels
refactoring
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
1 participant
@kuritka