Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when deleting ingress rule or annotations removal doesn't remove the gslb records #361

Closed
Zak-Anderson opened this issue Mar 10, 2021 · 4 comments · Fixed by #426
Closed
Labels
enhancement New feature or request
Milestone

Comments

@Zak-Anderson
Copy link

Zak-Anderson commented Mar 10, 2021

Hi Team

I have deployed the k8gb to a cluster with Kube 1.16.15

I have used the k8gb annotations for the ingress and deleted it

what I have found is that the gslb record does not get deleted but tries to get recreated although the ingress has been deleted.

is there a way by means of annotation removal or when ingress is deleted that the ingress >>>> gslb relationship works smoothly and seamlessly to delete the actual gslb record when the ingress is unannotated or deleted

I had to manually use

k delete gslb -n namespace namegslbingress

@kuritka kuritka added the bug Something isn't working label Mar 10, 2021
@ytsarev ytsarev added enhancement New feature or request and removed bug Something isn't working labels Mar 10, 2021
@ytsarev
Copy link
Member

ytsarev commented Mar 10, 2021

@kuritka it's not a bug. Annotation-based support was never meant to revert the initial ownership chain of Gslb -> automatically created Ingress under control. We created annotation-based propagation for the ease of adoption and integration with external tools to bootstrap Gslb CR.
We can definitely look into the creation of the reverse ownership, but it's not something we didn't anticipate so re-labeling as an enhancement.

@kuritka
Copy link
Collaborator

kuritka commented Mar 10, 2021

@ytsarev, thx for explaining 👍

@somaritane
Copy link
Contributor

There's another scenario that gets impacted by current behavior: replacement of already created gslb custom resources to Ingresses with gslb annotations.
In this case, user can't expect smooth automatic transition, as there's a need to manually intervene and delete all gslbs first.
And in case of self-healing GitOps deployments, this can get even more problematic.

@ytsarev ytsarev added this to the 0.8 milestone Mar 11, 2021
@ytsarev
Copy link
Member

ytsarev commented Mar 11, 2021

We need to fix it soon then. Included in the current 0.8 milestone

ytsarev added a commit that referenced this issue Apr 6, 2021
* Enables proper Ingress -> Gslb CR ownership in case of
annotation based management approach
with pre-existing Ingress as in

https://www.k8gb.io/docs/ingress_annotations.html

* Resolves #361

* Covered by Terratest

Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev added a commit that referenced this issue Apr 6, 2021
* Enables proper Ingress -> Gslb CR ownership in case of
annotation based management approach
with pre-existing Ingress as in

https://www.k8gb.io/docs/ingress_annotations.html

* Resolves #361

* Covered by Terratest

Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev added a commit that referenced this issue Apr 6, 2021
* Enables proper Ingress -> Gslb CR ownership in case of
annotation based management approach
with pre-existing Ingress as in

https://www.k8gb.io/docs/ingress_annotations.html

* Resolves #361

* Covered by Terratest

Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev added a commit that referenced this issue Apr 7, 2021
* Enables proper Ingress -> Gslb CR ownership in case of
annotation based management approach
with pre-existing Ingress as in

https://www.k8gb.io/docs/ingress_annotations.html

* Resolves #361

* Covered by Terratest

Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev added a commit that referenced this issue Apr 7, 2021
* Enables proper Ingress -> Gslb CR ownership in case of
annotation based management approach
with pre-existing Ingress as in

https://www.k8gb.io/docs/ingress_annotations.html

* Resolves #361

* Covered by Terratest

Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants