Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to own external-dns fork(again) #1134

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Apr 11, 2023

* Unfortunately upstream external-dns reviews take too long and we have
  to switch to own fork again(we did it before)
* Main motivation at the moment is to unblock Azure NS support
* Fork incorporates kubernetes-sigs/external-dns#2835

Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
kuritka
kuritka previously approved these changes Apr 12, 2023
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Yury Tsarev <yury@upbound.io>
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ytsarev ytsarev merged commit 92b9aab into k8gb-io:master Apr 12, 2023
@ytsarev ytsarev deleted the switch-to-external-dns-fork branch April 12, 2023 14:25
@ytsarev ytsarev mentioned this pull request Apr 12, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants