Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline Gslb Status #121

Merged
merged 1 commit into from
May 15, 2020
Merged

Streamline Gslb Status #121

merged 1 commit into from
May 15, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented May 14, 2020

  • Remove redundant ManagedHosts
  • Show external IP addresses in HealthyRecords even if local service
    is Unhealthy
  • Expose GeoTag
  • Resolves Streamline Gslb Status #116

@ytsarev
Copy link
Member Author

ytsarev commented May 14, 2020

It looks like that now

status:
  geoTag: eu
  healthyRecords:
    app3.cloud.example.com:
    - 172.17.0.3
    - 172.17.0.5
    - 172.17.0.6
  serviceHealth:
    app1.cloud.example.com: NotFound
    app2.cloud.example.com: Unhealthy
    app3.cloud.example.com: Healthy

kuritka
kuritka reviewed May 15, 2020
View reviewed changes
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good, I just left some comments.

@ytsarev ytsarev requested a review from kuritka May 15, 2020 09:13
@ytsarev
Streamline Gslb Status
e6ac68e 
* Remove redundant `ManagedHosts`
* Show external IP addresses in `HealthyRecords` even if local service
  is `Unhealthy`
* Expose `GeoTag`
* Resolves #116
@ytsarev ytsarev requested review from somaritane and kuritka May 15, 2020 10:14
somaritane
somaritane approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ytsarev ytsarev merged commit 9b191cd into master May 15, 2020
@ytsarev ytsarev deleted the status-kick branch May 15, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuritka kuritka kuritka approved these changes

@somaritane somaritane somaritane approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamline Gslb Status
3 participants
@ytsarev @somaritane @kuritka